-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xcvrd] change log content and log level when application is not found #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
approved these changes
Jun 18, 2024
mihirpat1
approved these changes
Jun 18, 2024
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-platform-daemons
that referenced
this pull request
Jun 21, 2024
Backport PR for 202311: #505 |
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-daemons
that referenced
this pull request
Jun 24, 2024
Cherry-pick PR to 202311: #506 |
mssonicbld
pushed a commit
that referenced
this pull request
Jun 24, 2024
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-platform-daemons
that referenced
this pull request
Jul 25, 2024
PR for 202405: #524 |
Hi @bingwang-ms , could you please help merge the PR for 202405? |
bingwang-ms
pushed a commit
that referenced
this pull request
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change log level to notice and add more information when application is not found for a module.
Motivation and Context
In existing setups, there might be ports that were set to admin down. Those ports may not have correct speed configuration which would cause error logs when applying media settings:
So, here is the thing:
So, I think it is safe to change the log level to NOTICE
How Has This Been Tested?
Manual test
Additional Information (Optional)